8357657: [11u][windows] cannot stat '/jdk.crypto.ec/*': No such file or directory #3035
Conversation
|
👋 Welcome back serb! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
@mrserb This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply issue a |
|
/touch |
|
@mrserb The pull request is being re-evaluated and the inactivity timeout has been reset. |
|
@mrserb This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a |
|
/keepalive |
|
@mrserb The pull request is being re-evaluated and the inactivity timeout has been reset. |
2 participants
This patch provides a workaround for a bug in the latest version of Cygwin. Only JDK 11 is affected; newer versions are not impacted because the makefiles were updated by JDK-8220383.
The issue is that:
ifneq ($(wildcard $(IMPORT_MODULES_CLASSES)/$(MODULE)), )returns results even when
IMPORT_MODULES_CLASSESis empty/unset. This causes the build to incorrectly search for a module like/jdk.crypto.ec/, which fails because the directory does not exist.The fix is to first check whether
IMPORT_MODULES_CLASSESis set. If it is, we defineIMPORT_MODULE_DIRas$(IMPORT_MODULES_CLASSES)/$(MODULE)and use this property consistently throughout the build. This matches the approach introduced in JDK-8220383 for this codepath.Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/3035/head:pull/3035$ git checkout pull/3035Update a local copy of the PR:
$ git checkout pull/3035$ git pull https://git.openjdk.org/jdk11u-dev.git pull/3035/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 3035View PR using the GUI difftool:
$ git pr show -t 3035Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/3035.diff
Using Webrev
Link to Webrev Comment